commit 23b4a0936f1ee11e587b7be9dc3bcae5b55d31cf
author Kenny Root <kroot@google.com> Thu Aug 05 16:21:23 2010 -0700
committer Alex Ray <aray@google.com> Tue Jul 30 13:56:54 2013 -0700
tree b79f05aebf10cfd278113b15d3b27911d0b106b2
parent 3da482eec2a6d893f80eb56c1670b0bc59b13c30

Fix String8::operator+

The LHS was ignored when using:
  String8 + String8
  String8 + (const char*)

Add unit tests for above.

Bug: 2898473
Change-Id: Ic8fe7be668b665c36aaaa3fc3c3ffdfff0fbba25

include/utils/String8.h

diff --git a/include/utils/String8.h b/include/utils/String8.h
index 0b18fe3..4e41410 100644
--- a/include/utils/String8.h
+++ b/include/utils/String8.h
@@ -374,7 +374,7 @@
 
 inline String8 String8::operator+(const String8& other) const
 {
-    String8 tmp;
+    String8 tmp(*this);
     tmp += other;
     return tmp;
 }
@@ -387,7 +387,7 @@
 
 inline String8 String8::operator+(const char* other) const
 {
-    String8 tmp;
+    String8 tmp(*this);
     tmp += other;
     return tmp;
 }