commit 451a6ba829ddfdf2c1d8605611342397340534df
author Todd Poynor <toddpoynor@google.com> Fri Apr 19 12:48:19 2013 -0700
committer Todd Poynor <toddpoynor@google.com> Mon Apr 22 11:07:14 2013 -0700
tree 1b1e8589c5e6f843b075a068249f38f7a6322b8e
parent ba4ac0cc3aa69075d6cbcee4eddb314ef753aa8d

klog: error handling fixups

Change-Id: I9014e62010c589ec30d5e99eef420353e35418b5

libcutils/klog.c

diff --git a/libcutils/klog.c b/libcutils/klog.c
index 812af3b..d69fb10 100644
--- a/libcutils/klog.c
+++ b/libcutils/klog.c
@@ -40,6 +40,8 @@
 
     if (mknod(name, S_IFCHR | 0600, (1 << 8) | 11) == 0) {
         klog_fd = open(name, O_WRONLY);
+        if (klog_fd < 0)
+                return;
         fcntl(klog_fd, F_SETFD, FD_CLOEXEC);
         unlink(name);
     }
@@ -54,6 +56,7 @@
 
     if (level > klog_level) return;
     if (klog_fd < 0) klog_init();
+    if (klog_fd < 0) return;
 
     va_start(ap, fmt);
     vsnprintf(buf, LOG_BUF_MAX, fmt, ap);